chore: show pubkey_hex at eotsd keys show and list
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
reviewed
Feb 4, 2025
RafilxTenfen
reviewed
Feb 4, 2025
RafilxTenfen
reviewed
Feb 4, 2025
samricotta
force-pushed
the
sam/show-pubkey
branch
3 times, most recently
from
dc3728a to
32521de
Compare
samricotta
force-pushed
the
sam/show-pubkey
branch
2 times, most recently
from
709a0c0 to
f902f20
Compare
eotsmanager/cmd/eotsd/daemon/keys.go
Outdated
| } | ||
|
|
||
| listCmd.RunE = runCommandPrintAllKeys | ||
| listCmd.Flags().StringP(flags.FlagOutput, "o", flags.OutputFormatText, "Output format (text|json)") |
There was a problem hiding this comment.
suggestion to remove this all good to use --output json
Suggested change
| listCmd.Flags().StringP(flags.FlagOutput, "o", flags.OutputFormatText, "Output format (text|json)") |
There was a problem hiding this comment.
Hmm when I remove this though, the test complains when using --output
There was a problem hiding this comment.
it shouldn't since it works locally, maybe there is something weird with the test setup
There was a problem hiding this comment.
babylon_e2e_test.go:407:
Error Trace: /home/runner/work/finality-provider/finality-provider/itest/babylon/babylon_e2e_test.go:407
Error: Received unexpected error:
flag accessed but not defined: output
Test: TestPrintEotsCmd
There was a problem hiding this comment.
humm, I had removed and run the test and it passes TestPrintEotsCmd
Lazar955
approved these changes
Feb 17, 2025
| panic("failed to find keys list command") | ||
| } | ||
|
|
||
| listCmd.RunE = runCommandPrintAllKeys |
There was a problem hiding this comment.
we could also remove CommandPrintAllKeys since now there is a keys ls subcommand
What do you think @Lazar955 ?
samricotta
force-pushed
the
sam/show-pubkey
branch
from
f8ae638 to
09ce71b
Compare
Lazar955
approved these changes
Feb 18, 2025
| panic("failed to find keys list command") | ||
| } | ||
|
|
||
| listCmd.RunE = runCommandPrintAllKeys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #274
When using the CLI the user can now retrieve their hex from show and list commands. Added in custom methods to replace the default SDK ones